Uh oh!
There was an error while loading. Please reload this page.
Reduce redundant Dag team lookups in authorization checks - #68020
Conversation
e8a6b1b to
d7b301eComparevincbeck
commented
Jun 4, 2026
CI is failing |
henry3260
left a comment
There was a problem hiding this comment.
looks good!test_bulk_delete_query_count_scales_linearly_with_task_count still asserts
the old exact counts, we should update it
Uh oh!
There was an error while loading. Please reload this page.
d7b301e to
7a919b3Compareyuseok89
commented
Jun 4, 2026
You're right, sorry. Once it was approved I moved it out of draft, but an approval isn't the same as a green CI, and I should have confirmed that first. The failure wasn't in the tests this change adds. Caching the Dag team lookup shaves one query off the bulk task-instance delete path, which tripped a pre-existing query-count regression guard there. That's the cross-area interaction I didn't catch. It's now fixed and pushed. |
Uh oh!
There was an error while loading. Please reload this page.
closes: #61485
requires_access_dagresolves a Dag's owning team viaDagModel.get_team_nameon every call — twice per grid endpoint (TASK_INSTANCE+RUN) and on every auto-refresh poll.This caches the lookup with a short per-process TTL.
Other large costs discussed in #61485 have already been addressed by separate PRs. I left the detailed breakdown in the issue comment, and this PR covers the remaining redundant Dag team lookup.
Impact
Team-ownership DB queries per grid page load:
Also included
[core] team_name_cache_ttl(default30s).Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.