Uh oh!
There was an error while loading. Please reload this page.
Detect Spark driver completion by container state when tracking via k8s API - #68048
Open
karenbraganz wants to merge 17 commits into
Open
Detect Spark driver completion by container state when tracking via k8s API#68048karenbraganz wants to merge 17 commits into
karenbraganz wants to merge 17 commits into
Conversation
CollaboratorAuthor
I still need to test this out and write unit tests. |
karenbraganz
commented
Jul 1, 2026
CollaboratorAuthor
This has passed all unit tests as well as a manual test that I ran. |
uranusjr
reviewed
Jul 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
reviewed
Aug 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
uranusjr
reviewed
Aug 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # providers/apache/spark/src/airflow/providers/apache/spark/operators/spark_submit.py
aaron-y-chen
left a comment
Contributor
There was a problem hiding this comment.
Should we also document the changes made in this PR in providers/apache/spark/docs/operators.rst?
| Raises ``RuntimeError`` on failure phases or unrecoverable API errors. | ||
| """ | ||
| pod_name = self._kubernetes_driver_pod | ||
| driver_container_name = self.kubernetes_driver_container |
Contributor
There was a problem hiding this comment.
Should we make the naming consistent? Like:
k8s_driver_container_name=self.k8s_driver_container_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
track_driver_via_k8s_api, detect driver completion by container status rather than pod phase #67934This PR tracks Spark job completion by container state instead of pod phase when
track_driver_via_k8s_api=True. Sometimes the pod continues to run even after the driver container completes due to other sidecar containers. This PR makes driver completion detection more accurate by examining the container itself.