') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix remote log provider type mismatch for callback-subprocess uploads by Lee-W · Pull Request #68290 · apache/airflow · GitHub
Skip to content

Fix remote log provider type mismatch for callback-subprocess uploads - #68290

Closed
Lee-W wants to merge 1 commit into
apache:mainfrom
astronomer:fix-mypy
Closed

Fix remote log provider type mismatch for callback-subprocess uploads#68290
Lee-W wants to merge 1 commit into
apache:mainfrom
astronomer:fix-mypy

Conversation

@Lee-W

@Lee-WLee-W commented Jun 9, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Why

Mypy fails in a recently created PR.

#66379 made RemoteLogIO.upload's ti optional (callback subprocess logs
have no task instance) but only updated Elasticsearch and Opensearch, leaving S3, CloudWatch, GCS, Wasb, Stackdriver, OSS and HDFS with a required ti so they no longer satisfied the RemoteLogIO protocol.

What

Widen the upload signature to accept an optional ti; the bodies don't use ti, so there is no behavior change.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude] following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Lee-W
Fix remote log provider type mismatch for callback-subprocess uploads
b902ad4
have no task instance) but only updated Elasticsearch and Opensearch,
leaving S3, CloudWatch, GCS, Wasb, Stackdriver, OSS and HDFS with a
required ti so they no longer satisfied the RemoteLogIO protocol. Widen
their upload signature to accept an optional ti; the bodies don't use
ti, so there is no behavior change.
yuseok89
yuseok89 approved these changes Jun 9, 2026
View reviewed changes

@yuseok89yuseok89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The CI failure appears unrelated and likely flaky.

@seanghaeli

seanghaeli commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the extension!

@Lee-W

Lee-W commented Jun 10, 2026

Copy link
Copy Markdown
MemberAuthor

close as #68300 is merged

@Lee-WLee-W closed this Jun 10, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner
2 more reviewers
@yuseok89yuseok89yuseok89 approved these changes
@seanghaeliseanghaeliseanghaeli approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:loggingarea:providersprovider:alibabaprovider:amazonAWS/Amazon - related issuesprovider:apache-hdfsprovider:googleGoogle (including GCP) related issuesprovider:microsoft-azureAzure-related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lee-W@seanghaeli@yuseok89