Uh oh!
There was an error while loading. Please reload this page.
Fix Supervisor crash in Stackdriver remote log IO - #68295
Closed
23tae wants to merge 1 commit into
Closed
Conversation
23taeforce-pushed
the
fix-gcl-supervisor-crash
branch
from
June 17, 2026 07:48
baa54c6 to
dbde7e6Compare23tae
commented
Jun 17, 2026
ContributorAuthor
@shahar1 Conflicts resolved. Thanks! |
eladkal
commented
Jun 17, 2026
Contributor
Does this PR solve #68240 ? |
23tae
commented
Jun 17, 2026
ContributorAuthor
23tae
marked this pull request as draft
June 18, 2026 04:43
ContributorAuthor
Putting this on hold — the |
potiuk
commented
Jul 8, 2026
Member
Note 🛠️ Maintainer triage note for @23tae · by This draft has been inactive for ~20 days, so I'm closing it to keep the review queue tidy — no judgment on the work itself. No rush — reopen it (or open a fresh PR) whenever you're ready to continue; nothing is lost. Automated triage — may be imperfect; a maintainer takes the next look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the Airflow 3 Supervisor process from crashing entirely when transient network or IAM errors occur during Stackdriver log transmission.
Description
This PR addresses Bug 3 described in #68240.
In the new Airflow 3 Task SDK architecture, the
StackdriverRemoteLogIOhandler runs within the Supervisor process rather than the task process itself. If an exception is raised during_transport.send(), it propagates upwards and crashes the entire Supervisor process, disrupting task monitoring.Key changes
_transport.send()call in atry...except Exceptionblock. When a transmission fails, the exception is safely caught, and a warning is logged using the internal_logger. This ensures the Supervisor process remains highly resilient.Verification Results
I have verified the changes using
prekandbreeze.related: #68240
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Note
✅ Ready for review · @23tae →
@potiuk· 2026-06-12 13:30 UTCThanks @23tae — all checks are green and this PR is marked ready for maintainer review. The ball is with the maintainers now; a maintainer will take the next look.
Automated triage — may be imperfect.