Skip to content

Remove stale dag_ parameter from create_test_pipeline docstring - #68787

Merged
shahar1 merged 1 commit into
apache:mainfrom
KenanAdel-M:remove-stale-dag-docstring
Jun 26, 2026
Merged

Remove stale dag_ parameter from create_test_pipeline docstring#68787
shahar1 merged 1 commit into
apache:mainfrom
KenanAdel-M:remove-stale-dag-docstring

Conversation

@KenanAdel-M

@KenanAdel-MKenanAdel-M commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Description

Remove a stale :param DAG dag_: docstring entry from the create_test_pipeline function in example_skip_dag.py.

The parameter is not present in the function signature and is not used anywhere in the code or call sites.

This change aligns the documentation with the actual implementation.

No functional changes are introduced.

Change Type

  • Documentation / Examples
Was generative AI tooling used to co-author this PR? No
  • Yes (please specify the tool below)

@boring-cyborg

boring-cyborgBot commented Jun 20, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@KenanAdel-M
KenanAdel-Mforce-pushed the remove-stale-dag-docstring branch from c23dc11 to bd22d2cCompareJune 20, 2026 20:35
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jun 25, 2026
@shahar1shahar1 added the backport-to-v3-3-test Backport to v3-3-test label Jun 26, 2026
@shahar1
shahar1 merged commit 473e332 into apache:mainJun 26, 2026
77 checks passed
@boring-cyborg

boring-cyborgBot commented Jun 26, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actionsgithub-actionsBot added this to the Airflow 3.3.1 milestone Jun 26, 2026
@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.1 based on: backport label targeting v3-3-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

github-actionsBot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
✅v3-3-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 26, 2026
@KenanAdel-MYour friendly bot
[v3-3-test] Remove stale dag_ parameter from create_test_pipeline d…
88b4431
…ocstring (apache#68787)
(cherry picked from commit 473e332)
Co-authored-by: Kenan Adel <kenanadel153@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 26, 2026
@KenanAdel-MYour friendly bot
[v3-3-test] Remove stale dag_ parameter from create_test_pipeline d…
2036870
…ocstring (apache#68787)
(cherry picked from commit 473e332)
Co-authored-by: Kenan Adel <kenanadel153@gmail.com>
potiuk pushed a commit that referenced this pull request Jun 26, 2026
@KenanAdel-M@potiuk
[v3-3-test] Remove stale dag_ parameter from create_test_pipeline d…
f220f5b
…ocstring (#68787)
(cherry picked from commit 473e332)
Co-authored-by: Kenan Adel <kenanadel153@gmail.com>
potiuk pushed a commit that referenced this pull request Jun 26, 2026
@github-actions@KenanAdel-M
[v3-3-test] Remove stale dag_ parameter from create_test_pipeline d…
9f5e0da
…ocstring (#68787) (#69013)
(cherry picked from commit 473e332)
Co-authored-by: Kenan Adel <kenanadel153@gmail.com>
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jun 30, 2026
@KenanAdel-M@karenbraganz
Remove staledag_parameter from create_test_pipeline docstring (ap…
bf6ab2b
…ache#68787)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahar1shahar1shahar1 approved these changes

Assignees

No one assigned

Labels

backport-to-v3-3-testBackport to v3-3-testready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Milestone

Airflow 3.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@KenanAdel-M@shahar1@potiuk