Uh oh!
There was an error while loading. Please reload this page.
Add feature-comparison table and toolset links to common.ai provider docs - #69649
Merged
Conversation
goransh-walia
commented
Jul 9, 2026
Nice clean implementation. One minor thought: adding a docstring would help future contributors. But overall this looks solid. |
…docs Reviewer feedback on apache#69551 (merged) asked for a scannable package-choice table linking to the vendor provider pages, a note that existing LangChain tools work via the langchain extra, and a link to the toolsets doc from the agent bullet.
…fy batch tradeoff Reviewer feedback on apache#69551 (merged) noted the comparison section ran before readers knew what the provider was, that OpenAIHook isn't batch-specific, and that the batch bullet didn't explain why one would pick it over a synchronous call.
…d batch cost/turnaround rationale Reviewer feedback on apache#69551 (merged) noted the comparison section ran before readers knew what the provider was, and that the batch bullet didn't explain why one would pick it over a synchronous call. The new clause reuses the cost/turnaround figures already documented in operators/anthropic.rst for consistency.
cohere is a third single-vendor AI provider shaped like openai/anthropic (wraps Cohere's own Embed API via one operator). It had no "when to use this provider" section, so common.ai's comparison table and vendor-provider bullet list couldn't link to it yet.
The lead-in sentence naming what each provider is was folded into the section body, so a reader still met the comparison heading before the one-line definition. Moving it above the heading, for openai, anthropic, and cohere.
1 task
…ider" heading Matches the same restructuring already applied to openai, anthropic, and cohere: a short definition sentence before the comparison heading, so a reader knows what the provider is before meeting the table.
Lee-Wforce-pushed
the
ai-provider-docs-followup
branch
from
July 9, 2026 10:01
55605b6 to
1d182dfCompareLee-W
marked this pull request as ready for review
July 9, 2026 10:03
kaxil
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addressing feedback on #69551 (merged)
OpenAIHookis the shared underlying client (not batch-specific); added the Batch API cost/turnaround rationale (~half cost, up to ~24h turnaround).operators/anthropic.rst.LangChainToolsetwith thelangchainextraWas generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.