Skip to content

Make cheat-sheet test independent of rich table padding - #69802

Merged
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-rich
Jul 15, 2026
Merged

Make cheat-sheet test independent of rich table padding#69802
Lee-W merged 1 commit into
apache:mainfrom
FrankYang0529:airflow-rich

Conversation

@FrankYang0529

@FrankYang0529FrankYang0529 commented Jul 13, 2026

Copy link
Copy Markdown
Member

Why

How

  • Ignore padding space. Rewrite the expected rows in single-space form and normalize runs of spaces in the captured output before asserting.

Verification

  • uv run --frozen --project airflow-core --with ./shared/secrets_masker pytest airflow-core/tests/unit/cli/commands/test_cheat_sheet_command.py
  • uv run --frozen --project airflow-core --with ./shared/secrets_masker --with "rich==14.3.4" pytest airflow-core/tests/unit/cli/commands/test_cheat_sheet_command.py
Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@FrankYang0529
Make cheat-sheet test independent of rich table padding
e0babfa
Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 marked this pull request as ready for review July 13, 2026 08:16
Lee-W
Lee-W approved these changes Jul 13, 2026
View reviewed changes

@Lee-WLee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to me

@Miretpl

Miretpl commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Not sure if this should be backported to 3.x version branch or not 🤔

@Lee-W

Lee-W commented Jul 15, 2026

Copy link
Copy Markdown
Member

Not sure if this should be backported to 3.x version branch or not 🤔

sounds good. let me do it

@Lee-WLee-W added the backport-to-v3-3-test Backport to v3-3-test label Jul 15, 2026
@Lee-W
Lee-W merged commit fc51ac9 into apache:mainJul 15, 2026
138 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.3.1 milestone Jul 15, 2026
@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.1 based on: backport label targeting v3-3-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
✅v3-3-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 15, 2026
@FrankYang0529Your friendly bot
[v3-3-test] Make cheat-sheet test independent of rich table padding (a…
8846f49
…pache#69802)
(cherry picked from commit fc51ac9)
Co-authored-by: PoAn Yang <yangpoan@gmail.com>
Signed-off-by: PoAn Yang <payang@apache.org>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 15, 2026
@FrankYang0529Your friendly bot
[v3-3-test] Make cheat-sheet test independent of rich table padding (a…
3a027b3
…pache#69802)
(cherry picked from commit fc51ac9)
Co-authored-by: PoAn Yang <yangpoan@gmail.com>
Signed-off-by: PoAn Yang <payang@apache.org>
@amoghrajeshamoghrajesh mentioned this pull request Jul 15, 2026
Closed
1 task
@FrankYang0529
FrankYang0529 deleted the airflow-rich branch July 15, 2026 05:32
Lee-W pushed a commit that referenced this pull request Jul 15, 2026
@github-actions@FrankYang0529
[v3-3-test] Make cheat-sheet test independent of rich table padding (#…
fee0aac
…69802) (#69892)
(cherry picked from commit fc51ac9)
Signed-off-by: PoAn Yang <payang@apache.org>
Co-authored-by: PoAn Yang <yangpoan@gmail.com>
joshuabvarghese pushed a commit to joshuabvarghese/airflow that referenced this pull request Jul 16, 2026
@FrankYang0529@joshuabvarghese
Make cheat-sheet test independent of rich table padding (apache#69802)
f177037
Signed-off-by: PoAn Yang <payang@apache.org>
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
@github-actions@FrankYang0529@vatsrahul1001
[v3-3-test] Make cheat-sheet test independent of rich table padding (#…
3f64a97
…69802) (#69892)
(cherry picked from commit fc51ac9)
Signed-off-by: PoAn Yang <payang@apache.org>
Co-authored-by: PoAn Yang <yangpoan@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes
@MiretplMiretplMiretpl approved these changes

Assignees

No one assigned

Labels

area:CLIbackport-to-v3-3-testBackport to v3-3-test

Projects

None yet

Milestone

Airflow 3.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@FrankYang0529@Miretpl@Lee-W