Split airflowctl dags state argument into run_id and --logical-date by FrankYang0529 · Pull Request #69915 · apache/airflow

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 · 2026-07-15T10:47:46Z

Why

Followup from Add airflowctl tasks failed-deps command #69397 (comment).
The core airflow dags state used single field logical_date_or_run_id for two different values. The airflowctl dags state inherited it.
If the input is a logical_date, it spends an extra request trying it as a run_id first. That request is bound to 404, and the CLI then uses the list API to retrieve the dag_run. An unknown run_id has a similar issue: the 404 is followed by a list call issued only to check that the Dag exists.

How

Add --logical-date and make run_id an optional positional. Exactly one of the two is required.
run_id goes straight to dag_runs.get and --logical-date goes to dag_runs.list.

Verification

uv run --project airflow-ctl pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py airflow-ctl/tests/airflow_ctl/api/test_operations.py

related: [AIP-94] airflowctl command migration #68402

Was generative AI tooling used to co-author this PR?

Yes - Claude Code

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: PoAn Yang <payang@apache.org>

Lee-W · 2026-07-23T02:07:26Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

bugraoz93 · 2026-07-23T18:21:29Z

@bugraoz93 Since we've not yet released 1.0.0, I think we don't need to worry about breaking change?

Exactly @Lee-W, good to go. Thanks for checking!

Discussion still needs attention from community for 1.0. We will release 0.1.x versions until we agree on 1.0 maturity

bugraoz93 · 2026-07-23T18:21:54Z

Let see CI integration tests and merge :)

github-actions · 2026-07-24T02:24:16Z

Backport successfully created: airflow-ctl/v0-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	airflow-ctl/v0-1-test

…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

The dags state backport (apache#69915, apache#70352) brought the caller and the tests but dropped suppress_error_log from DagRunOperations.list(), which main has. dag_command.py:147 passes it, so the command raised: TypeError: DagRunOperations.list() got an unexpected keyword argument 'suppress_error_log' Restore the keyword-only parameter and forward it to the client as the airflowctl_suppress_error_log extension, matching the sibling get(). The broken caller only exists on this test branch, so no released airflowctl is affected and no newsfragment is needed.

…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>

boring-cyborgBot added area:airflow-ctl backport-to-airflow-ctl/v0-1-test labels Jul 15, 2026

FrankYang0529 force-pushed the airflow-dags-state branch from 72be3ef to 6cae126Compare July 15, 2026 10:50

FrankYang0529 mentioned this pull request Jul 15, 2026
Add airflowctl tasks failed-deps command #69397
Merged
1 task

FrankYang0529 marked this pull request as ready for review July 16, 2026 00:14

FrankYang0529 requested review from amoghrajesh, ashb, bugraoz93, dheerajturaga, gopidesupavan, henry3260, jason810496 and potiuk as code owners July 16, 2026 00:14

Lee-W reviewed Jul 22, 2026
View reviewed changes

Comment threadairflow-ctl/src/airflowctl/ctl/commands/dag_command.py Outdated
Comment threadairflow-ctl/src/airflowctl/ctl/commands/dag_command.py Outdated
Comment threadairflow-ctl/tests/airflow_ctl/ctl/commands/test_dag_command.py Outdated

Split airflowctl dags state argument into run_id and --logical-date
52dc407
Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 force-pushed the airflow-dags-state branch from 6cae126 to 52dc407Compare July 22, 2026 12:53

Lee-W approved these changes Jul 23, 2026
View reviewed changes

bugraoz93 added the full tests needed We need to run full set of tests for this PR to merge label Jul 23, 2026

bugraoz93 closed this Jul 23, 2026

bugraoz93 reopened this Jul 23, 2026

bugraoz93 approved these changes Jul 23, 2026
View reviewed changes

Lee-W merged commit b33558e into apache:mainJul 24, 2026
249 checks passed

Lee-W pushed a commit that referenced this pull request Jul 24, 2026
[airflow-ctl/v0-1-test] Split airflowctl dags state argument into run…
bff3027
…_id and --logical-date (#69915) (#70352) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>

FrankYang0529 deleted the airflow-dags-state branch July 24, 2026 02:37

rjgoyln mentioned this pull request Aug 1, 2026
Share airflowctl's Dag run lookup without a new request for run_id #70904
Open
1 task

Lee-W mentioned this pull request Aug 4, 2026
Fix airflowctl dags state crash from an incomplete backport #71095
Merged
1 task

dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
Split airflowctl dags state argument into run_id and --logical-date (a…
6bdcae3
…pache#69915) Signed-off-by: PoAn Yang <payang@apache.org>