Skip to content

Fix stale conn-id fallback assertion for cloudwatch remote logging - #70210

Merged
Lee-W merged 1 commit into
apache:mainfrom
astronomer:fix-stale-conn-id-fallback-assert
Jul 22, 2026
Merged

Fix stale conn-id fallback assertion for cloudwatch remote logging#70210
Lee-W merged 1 commit into
apache:mainfrom
astronomer:fix-stale-conn-id-fallback-assert

Conversation

@Lee-W

@Lee-WLee-W commented Jul 22, 2026

Copy link
Copy Markdown
Member

Provider dispatch (added for cloudwatch in #69816) intentionally drops the hook's default_conn_name fallback, so an unset remote_log_conn_id no longer resolves to aws_default. test_remote_logging_conn's no-conn-id case expected the old fallback and failed on main; update it to expect no connection env var.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Provider dispatch (added for cloudwatch in apache#69816) intentionally drops
the hook's default_conn_name fallback, so an unset remote_log_conn_id
no longer resolves to aws_default. test_remote_logging_conn's
no-conn-id case expected the old fallback and failed on main; update
it to expect no connection env var.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR (#69816) didn't trigger the task-sdk tests back then. I just came across the same CI failure a few seconds ago. Thanks for fixing this! (Just about to fix this and you raise the PR!)

@Lee-W

Copy link
Copy Markdown
MemberAuthor

yep, my pr encountered this issue haha. let's see how CI goes this time

@Lee-W
Lee-W merged commit ab54125 into apache:mainJul 22, 2026
107 checks passed
@Lee-W
Lee-W deleted the fix-stale-conn-id-fallback-assert branch July 22, 2026 05:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Lee-W@jason810496@guan404ming