Skip to content

airflowctl: Fix datetime.datetime CLI parameter parsing - #70250

Closed
guptakushal03 wants to merge 1 commit into
apache:mainfrom
guptakushal03:fix/airflowctl-datetime-parsing
Closed

airflowctl: Fix datetime.datetime CLI parameter parsing#70250
guptakushal03 wants to merge 1 commit into
apache:mainfrom
guptakushal03:fix/airflowctl-datetime-parsing

Conversation

@guptakushal03

@guptakushal03guptakushal03 commented Jul 22, 2026

Copy link
Copy Markdown

Fixes datetime.datetime-typed CLI parameter parsing in airflowctl.

Previously, datetime.datetime parameters were mapped directly to the datetime.datetime constructor, causing valid ISO-8601 datetime strings (for example, 2026-07-01 and 2026-07-01T14:30:00) to be rejected by argparse.

This change:

  • Adds iso_datetime_type() to parse ISO-8601 datetime strings using datetime.datetime.fromisoformat().
  • Updates datetime.datetime-typed CLI arguments to use the parser instead of the bare constructor.
  • Adds unit tests covering valid datetime inputs and invalid values that should raise argparse.ArgumentTypeError.

closes: #70232


Was generative AI tooling used to co-author this PR?
  • Yes (ChatGPT)

Generated-by: ChatGPT following the guidelines.


Important

🛠️ Maintainer triage note for @guptakushal03 · by @potiuk · 2026-08-13 12:55 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed:

  • Merge conflicts. See docs.
  • Pre-commit / static checks. See docs.

Full list of what we check: Pull Request quality criteria.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

Automated triage — may be imperfect; a maintainer takes the next look.

@boring-cyborg

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk

Copy link
Copy Markdown
Member

Thanks — and sorry to close it.

This overlaps #70249, opened the same day, which fixes the same _python_type_from_string type map. #70249 is the broader fix: it repairs both datetime.date and datetime.datetime (this PR covers only datetime.datetime, leaving date-typed parameters still broken), normalises the trailing Z the API actually emits, passes already-typed values through unchanged, and adds an end-to-end test that the generated dagrun list --start-date argument parses.

Going with #70249 so both halves land together rather than in two passes. It has changes requested outstanding, so it isn't finished either — but the shape is the one to build on.

Closing in its favour. The diagnosis was correct, and the argparse.ArgumentTypeError approach matches what #70249 landed on.


Drafted by an AI assistant and may contain mistakes — if you think this call is wrong, say so and the PR will be reopened; a human maintainer has the final word.

Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiukpotiuk closed this Aug 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

airflowctl: datetime.datetime-typed CLI parameters don't accept any value

2 participants

@guptakushal03@potiuk