Uh oh!
There was an error while loading. Please reload this page.
airflowctl: Fix datetime.datetime CLI parameter parsing - #70250
airflowctl: Fix datetime.datetime CLI parameter parsing#70250guptakushal03 wants to merge 1 commit into
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
potiuk
commented
Aug 17, 2026
Thanks — and sorry to close it. This overlaps #70249, opened the same day, which fixes the same Going with #70249 so both halves land together rather than in two passes. It has changes requested outstanding, so it isn't finished either — but the shape is the one to build on. Closing in its favour. The diagnosis was correct, and the Drafted by an AI assistant and may contain mistakes — if you think this call is wrong, say so and the PR will be reopened; a human maintainer has the final word. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Fixes
datetime.datetime-typed CLI parameter parsing inairflowctl.Previously,
datetime.datetimeparameters were mapped directly to thedatetime.datetimeconstructor, causing valid ISO-8601 datetime strings (for example,2026-07-01and2026-07-01T14:30:00) to be rejected byargparse.This change:
iso_datetime_type()to parse ISO-8601 datetime strings usingdatetime.datetime.fromisoformat().datetime.datetime-typed CLI arguments to use the parser instead of the bare constructor.argparse.ArgumentTypeError.closes: #70232
Was generative AI tooling used to co-author this PR?
Generated-by: ChatGPT following the guidelines.
Important
🛠️ Maintainer triage note for @guptakushal03 · by
@potiuk· 2026-08-13 12:55 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
Full list of what we check: Pull Request quality criteria.
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.