Uh oh!
There was an error while loading. Please reload this page.
Remove airflow-metadata.yaml sidecar support from NodeCoordinator - #70273
Merged
jason810496 merged 1 commit intoJul 23, 2026
Merged
Conversation
airflow-ts-pack always embeds the bundle metadata in bundle.mjs itself, so the sidecar fallback re-introduces the metadata drift the embedding was built to prevent, and no tool produces the file. NodeCoordinator has not shipped in any task-sdk release yet, so the fallback can be dropped without a compatibility path.
guan404ming
approved these changes
Jul 23, 2026
guan404ming
left a comment
Member
There was a problem hiding this comment.
LGTM, verified locally and worked as expected.
Uh oh!
There was an error while loading. Please reload this page.
dabla pushed a commit
to dabla/airflow
that referenced
this pull request
Aug 14, 2026
…ache#70273) airflow-ts-pack always embeds the bundle metadata in bundle.mjs itself, so the sidecar fallback re-introduces the metadata drift the embedding was built to prevent, and no tool produces the file. NodeCoordinator has not shipped in any task-sdk release yet, so the fallback can be dropped without a compatibility path.
1 task
jason810496 pushed a commit
that referenced
this pull request
Aug 27, 2026
…72115) The NodeCoordinator config table still described bundles_root as accepting a bundle.mjs with an airflow-metadata.yaml sidecar, but that fallback was removed in #70273 and the coordinator now only reads metadata embedded in the bundle by airflow-ts-pack. The packing section also jumped straight to running airflow-ts-pack without showing that apache-airflow-ts-sdk and its optional esbuild peer dependency need to be installed first, so following the doc as written fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflow-ts-pack), Add NodeCoordinator #68548 (NodeCoordinator)Why
airflow-ts-packalways embeds the bundle metadata intobundle.mjsitself as a leading//# airflowMetadata=<base64>comment but theNodeCoordinatorfallback that accepts a hand-writtenairflow-metadata.yaml. However, no tool produces theairflow-metadata.yamlfile.What
NodeCoordinatornow treats the embedded metadata as the only accepted source: abundle.mjswithout the//# airflowMetadata=marker is rejected with `"bundle.mjs has no embedded airflow metadata.Was generative AI tooling used to co-author this PR?