Skip to content

Mount ts-sdk sources in Breeze container - #70278

Merged
jason810496 merged 1 commit into
apache:mainfrom
jason810496:fix/breeze/mount-ts-sdk-sources
Jul 23, 2026
Merged

Mount ts-sdk sources in Breeze container#70278
jason810496 merged 1 commit into
apache:mainfrom
jason810496:fix/breeze/mount-ts-sdk-sources

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

ts-sdk/ is the only language-SDK distribution missing from Breeze's VOLUMES_FOR_SELECTED_MOUNTS allowlist and the .dockerignore build-context allowlist, so unlike task-sdk, go-sdk, and java-sdk it never appears under /opt/airflow in Breeze shells (default MOUNT_SELECTED mode) or in the CI image.

What

  • Add ts-sdk to VOLUMES_FOR_SELECTED_MOUNTS in docker_command_utils.py so it is bind-mounted at /opt/airflow/ts-sdk.
  • Add !ts-sdk/ to the .dockerignore allowlist for parity with the other SDK distributions (**/node_modules stays excluded).
  • Regenerate scripts/ci/docker-compose/local.yml via breeze setup synchronize-local-mounts.

Verification

$ breeze run ls /opt/airflow/ts-sdkLICENSENOTICEREADME.mdeslint.config.jsexamplepackage.jsonpnpm-lock.yamlscriptssrcteststsconfig.build.jsontsconfig.jsonvitest.config.ts

Was generative AI tooling used to co-author this PR?

@phanikumvphanikumv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified locally.

ts-sdk was the only language-SDK distribution missing from the
MOUNT_SELECTED allowlist and the .dockerignore build-context allowlist,
so unlike task-sdk, go-sdk, and java-sdk it never appeared under
/opt/airflow in Breeze shells or in the CI image.
@jason810496
jason810496force-pushed the fix/breeze/mount-ts-sdk-sources branch from 55947d9 to a80dc3fCompareJuly 23, 2026 11:21

@guan404mingguan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jason810496
jason810496 merged commit 1fd0d41 into apache:mainJul 23, 2026
155 checks passed
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
ts-sdk was the only language-SDK distribution missing from the
MOUNT_SELECTED allowlist and the .dockerignore build-context allowlist,
so unlike task-sdk, go-sdk, and java-sdk it never appeared under
/opt/airflow in Breeze shells or in the CI image.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jason810496@amoghrajesh@phanikumv@guan404ming