Skip to content

Fix deadline serialization, repr, and prune edge cases - #70421

Merged
o-nikolas merged 8 commits into
apache:mainfrom
aws-mwaa:feature/deadline-robustness-followup
Aug 17, 2026
Merged

Fix deadline serialization, repr, and prune edge cases#70421
o-nikolas merged 8 commits into
apache:mainfrom
aws-mwaa:feature/deadline-robustness-followup

Conversation

@seanghaeli

@seanghaeliseanghaeli commented Jul 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Split out of #68919 per review. Edge-case fixes in the deadline model and serialization paths:

  • Deserialization routes by __class_path ahead of reference_type (custom references can share a builtin's class name), and a reference with no importable __class_path raises a clear error instead of a KeyError.
  • __repr__ on Deadline and DeadlineAlert never raises (guards the dagrun relationship post-cascade-delete and the dict-shaped interval).
  • prune_deadlines excludes missed deadlines so a missed deadline's queued callback is not cascade-deleted.

@seanghaeli
Harden deadline serialization, repr, and prune paths
f0d7910
Split out of apache#68919 per review: decoder __class_path routing, clear
error for missing __class_path, repr guards for severed dagrun and
dict-shaped interval, and prune guard for missed deadlines.
@seanghaeliseanghaeli mentioned this pull request Jul 24, 2026
Merged
@seanghaeliseanghaeli changed the title Harden deadline serialization, repr, and prune pathsFix deadline serialization, repr, and prune edge casesJul 24, 2026
@seanghaeli
seanghaeli marked this pull request as ready for review July 25, 2026 00:14
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 28, 2026
@seanghaeli
seanghaeliforce-pushed the feature/deadline-robustness-followup branch from 09a9f50 to 385914dCompareJuly 28, 2026 22:32
ferruzzi
ferruzzi reviewed Aug 7, 2026
View reviewed changes
Comment threadairflow-core/src/airflow/serialization/definitions/deadline.py
Comment threadairflow-core/tests/unit/models/test_prune_deadlines.py Outdated
Comment threadairflow-core/tests/unit/models/test_prune_deadlines.py Outdated
Comment threadairflow-core/tests/unit/models/test_prune_deadlines.py Outdated
Comment threadairflow-core/tests/unit/models/test_prune_deadlines.py Outdated
Comment threadairflow-core/tests/unit/models/test_deadline_alert.py Outdated
Comment threadairflow-core/src/airflow/models/deadline_alert.py
@ferruzziferruzzi added the backport-to-v3-3-test Backport to v3-3-test label Aug 13, 2026
@o-nikolas
o-nikolas merged commit f03b3bb into apache:mainAug 17, 2026
77 checks passed
@o-nikolas
o-nikolas deleted the feature/deadline-robustness-followup branch August 17, 2026 16:56
@github-actionsgithub-actionsBot added this to the Airflow 3.3.2 milestone Aug 17, 2026
@github-actions

github-actionsBot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: backport label targeting v3-3-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

github-actionsBot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
✅v3-3-testPR Link

potiuk pushed a commit that referenced this pull request Aug 17, 2026
@seanghaeli@potiuk
[v3-3-test] Fix deadline serialization, repr, and prune edge cases (#…
f293c03
…70421)
Split out of #68919 per review: decoder __class_path routing, clear
error for missing __class_path, repr guards for severed dagrun and
dict-shaped interval, and prune guard for missed deadlines.
(cherry picked from commit f03b3bb)
Co-authored-by: Sean Ghaeli <58916776+seanghaeli@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Aug 17, 2026
@github-actions@seanghaeli
[v3-3-test] Fix deadline serialization, repr, and prune edge cases (#…
7474831
…70421) (#71726)
Split out of #68919 per review: decoder __class_path routing, clear
error for missing __class_path, repr guards for severed dagrun and
dict-shaped interval, and prune guard for missed deadlines.
(cherry picked from commit f03b3bb)
Co-authored-by: Sean Ghaeli <58916776+seanghaeli@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferruzziferruzziferruzzi approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@bolkedebruinbolkedebruinAwaiting requested review from bolkedebruinbolkedebruin is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner

Assignees

No one assigned

Labels

area:DAG-processingarea:deadline-alertsAIP-86 (former AIP-57)backport-to-v3-3-testBackport to v3-3-testready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Milestone

Airflow 3.3.2

Development

Successfully merging this pull request may close these issues.

4 participants

@seanghaeli@ferruzzi@potiuk@o-nikolas