') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Fix DbtCloudRunJobOperator having false failures during deferred polling by amoghrajesh · Pull Request #70581 · apache/airflow · GitHub
Skip to content

Fix DbtCloudRunJobOperator having false failures during deferred polling - #70581

Merged
amoghrajesh merged 2 commits into
apache:mainfrom
astronomer:worktree-fix-dbtcloud-async-connection-70398
Jul 30, 2026
Merged

Fix DbtCloudRunJobOperator having false failures during deferred polling#70581
amoghrajesh merged 2 commits into
apache:mainfrom
astronomer:worktree-fix-dbtcloud-async-connection-70398

Conversation

@amoghrajesh

@amoghrajeshamoghrajesh commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
Was generative AI tooling used to co-author this PR?
  • Yes

closes: #70398

Why?

Deferred DbtCloudRunJobOperator tasks failed within seconds of deferring with a misleading DbtCloudJobRunException: Job run <id> has failed, even though the dbt Cloud job kept running and completed successfully hours later.

What

DbtCloudHook.get_headers_tenants_from_connection() and get_job_details() resolved the connection through the hook's synchronous connection cached_property while running inside the triggerer's live event loop. That
path masks the connection's secret via a synchronous comms call, which asgiref rejects when called from a thread already running an event loop the resulting RuntimeError propagated up through the trigger and was surfaced by the operator as a job failure instead of the real (transient) error it was.

Both call sites now resolve the connection through the existing async safe get_async_connection() helper, sharing a cache slot with the sync connection cached_property so neither path performs a duplicate connection lookup. Also switched the file's Connection type import to the airflow.providers.common.compat.sdk compat shim (matching what
get_connection()/get_async_connection() actually return under Airflow 3), which let a stale # type: ignore[return-value] on the connection property be removed.

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@amoghrajeshamoghrajesh self-assigned this Jul 28, 2026
Lee-W
Lee-W reviewed Jul 28, 2026
View reviewed changes
Comment threadproviders/dbt/cloud/src/airflow/providers/dbt/cloud/hooks/dbt.py
@amoghrajesh
amoghrajesh requested a review from Lee-WJuly 29, 2026 12:09
@amoghrajesh
amoghrajesh merged commit 13d7df7 into apache:mainJul 30, 2026
78 checks passed
@amoghrajesh
amoghrajesh deleted the worktree-fix-dbtcloud-async-connection-70398 branch July 30, 2026 04:55
This was referenced Aug 3, 2026
Closed
Closed
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
@amoghrajesh@dabla
Fix DbtCloudRunJobOperator having false failures during deferred poll…
ecf1804
…ing (apache#70581)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-WLee-WLee-W approved these changes
@eladkaleladkaleladkal approved these changes
@potiukpotiukAwaiting requested review from potiuk
@kaxilkaxilAwaiting requested review from kaxil
@pankajkotipankajkotiAwaiting requested review from pankajkoti
@shahar1shahar1Awaiting requested review from shahar1
@jason810496jason810496Awaiting requested review from jason810496
@pankajastropankajastroAwaiting requested review from pankajastro
@josh-felljosh-fellAwaiting requested review from josh-felljosh-fell is a code owner

Assignees

@amoghrajeshamoghrajesh

Labels

area:providersprovider:dbt-cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deferred DbtCloudRunJobOperator (and similar triggers) fail spuriously via mask_secret() cross-event-loop RuntimeError in _get_connection()

3 participants

@amoghrajesh@Lee-W@eladkal