Skip to content

Add the Taiwanese Mandarin string for variable-interval deadlines - #70655

Merged
Lee-W merged 1 commit into
apache:mainfrom
astronomer:ui-deadline-dynamic-interval
Jul 29, 2026
Merged

Add the Taiwanese Mandarin string for variable-interval deadlines#70655
Lee-W merged 1 commit into
apache:mainfrom
astronomer:ui-deadline-dynamic-interval

Conversation

@Lee-W

@Lee-WLee-W commented Jul 29, 2026•
edited
Loading

Copy link
Copy Markdown
Member

as title

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@Lee-W
Lee-W marked this pull request as ready for review July 29, 2026 04:37
@Lee-WLee-W changed the title Show a readable label for deadline alerts with a dynamic intervalFix deadline alerts showing wrong duration for dynamic intervals（Jul 29, 2026
@shahar1

shahar1 commented Jul 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

I've already this to handle that: #70637
Feel free to adjust this PR for more improvements, if you find necessary :)

@Lee-W
Add the Taiwanese Mandarin string for variable-interval deadlines
6e5ad19
The English string added with the variable-interval deadline fix had no
zh-TW counterpart, so readers of that locale saw an untranslated sentence
in the middle of an otherwise translated deadline panel.
@Lee-W
Lee-Wforce-pushed the ui-deadline-dynamic-interval branch from 225e787 to 6e5ad19CompareJuly 29, 2026 07:43
@Lee-WLee-W changed the title Fix deadline alerts showing wrong duration for dynamic intervals（Add the Taiwanese Mandarin string for variable-interval deadlinesJul 29, 2026
@Lee-W

Lee-W commented Jul 29, 2026

Copy link
Copy Markdown
MemberAuthor

I guess the only thing left is translation haha

guan404ming
guan404ming approved these changes Jul 29, 2026
View reviewed changes

@guan404mingguan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lee-W
Lee-W merged commit 4601fb0 into apache:mainJul 29, 2026
88 checks passed
@Lee-W
Lee-W deleted the ui-deadline-dynamic-interval branch July 29, 2026 14:14
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
@Lee-W@dabla
Add the Taiwanese Mandarin string for variable-interval deadlines (ap…
bdf6436
…ache#70655)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guan404mingguan404mingguan404ming approved these changes
@jason810496jason810496Awaiting requested review from jason810496jason810496 is a code owner
@henry3260henry3260Awaiting requested review from henry3260henry3260 is a code owner
@bbovenzibbovenziAwaiting requested review from bbovenzi
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrun
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-git
@vatsrahul1001vatsrahul1001Awaiting requested review from vatsrahul1001
@choo121600choo121600Awaiting requested review from choo121600

Assignees

No one assigned

Labels

area:translationsarea:UIRelated to UI/UX. For Frontend Developers.translation:defaulttranslation:zh-TW

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lee-W@shahar1@guan404ming