Skip to content

Fix some docs and test gaps following up multi team secret refusal - #71106

Merged
amoghrajesh merged 4 commits into
apache:mainfrom
astronomer:teams-check-providers-followup
Aug 5, 2026
Merged

Fix some docs and test gaps following up multi team secret refusal#71106
amoghrajesh merged 4 commits into
apache:mainfrom
astronomer:teams-check-providers-followup

Conversation

@amoghrajesh

Copy link
Copy Markdown
Contributor

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Post-merge follow up to #71078, addressing review comments from
#71078 (review):

  • Updated the Google Cloud Secret Manager backend docs (google-cloud-secret-manager-backend.rst)
    to reflect that the "--" ambiguous-id refusal only applies when [core] multi_team
    is enabled, replacing the outdated "rename it" advice with the actual silent
    stops-resolving-on-upgrade behavior.
  • Strengthened test_ambiguous_id_resolves_when_multi_team_is_disabled in test_key_vault.py to assert the actual resolved secret name for all three lookups (connection, variable, config), not just the mocked return value.
  • Aligned test_systems_manager.py with the multi_team_enabled module-level constant convention already used by the other four secrets-backend test files

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@amoghrajeshamoghrajesh self-assigned this Aug 5, 2026
@amoghrajesh

Copy link
Copy Markdown
ContributorAuthor

Unrelated failures, merging.

@amoghrajesh
amoghrajesh merged commit 2d0ec09 into apache:mainAug 5, 2026
78 of 81 checks passed
@amoghrajesh
amoghrajesh deleted the teams-check-providers-followup branch August 5, 2026 14:30
@potiukpotiuk mentioned this pull request Aug 6, 2026
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersarea:secretskind:documentationprovider:amazonAWS/Amazon - related issuesprovider:googleGoogle (including GCP) related issuesprovider:microsoft-azureAzure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@amoghrajesh@kaxil