Skip to content

UI: Allow file downloads from plugin external view iframes - #71803

Merged
bbovenzi merged 2 commits into
apache:mainfrom
haseebmalik18:external-view-allow-downloads
Aug 21, 2026
Merged

UI: Allow file downloads from plugin external view iframes#71803
bbovenzi merged 2 commits into
apache:mainfrom
haseebmalik18:external-view-allow-downloads

Conversation

@haseebmalik18

@haseebmalik18haseebmalik18 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Plugin external_views render in a sandboxed iframe missing allow-downloads, so the browser blocks any download from a plugin page. This adds the token. Safe because the sandbox already grants allow-scripts + allow-same-origin, which per MDN already lets same origin content drop the sandbox entirely. Same reasoning as #52257 , which added allow-scripts here for the same class of bug.

Verified in Chrome 141 and Firefox 153

closes: #71797

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (Opus 5) following the guidelines

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 18, 2026
@bbovenzibbovenzi added this to the Airflow 3.3.2 milestone Aug 21, 2026
@bbovenzibbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Aug 21, 2026
@bbovenzi
bbovenzi merged commit d253d87 into apache:mainAug 21, 2026
89 checks passed
@github-actions

github-actionsBot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
✅v3-3-testPR Link

bbovenzi pushed a commit that referenced this pull request Aug 24, 2026
@github-actions@haseebmalik18
[v3-3-test] UI: Allow file downloads from plugin external view iframes (
8c2e08c
#71803) (#71952)
(cherry picked from commit d253d87)
Co-authored-by: Haseeb Malik <118837269+haseebmalik18@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@guan404mingguan404mingAwaiting requested review from guan404mingguan404ming is a code owner
@vatsrahul1001vatsrahul1001Awaiting requested review from vatsrahul1001vatsrahul1001 is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees

No one assigned

Labels

area:UIRelated to UI/UX. For Frontend Developers.backport-to-v3-3-testBackport to v3-3-test

Projects

None yet

Milestone

Airflow 3.3.2

Development

Successfully merging this pull request may close these issues.

File downloads are not allowed using external_views

2 participants

@haseebmalik18@bbovenzi