Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Honor the API server Dag cache TTL when no size limit is set by jason810496 · Pull Request #71814 · apache/airflow · GitHub
Skip to content

Honor the API server Dag cache TTL when no size limit is set - #71814

Merged
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored
Aug 19, 2026
Merged

Honor the API server Dag cache TTL when no size limit is set#71814
jason810496 merged 5 commits into
apache:mainfrom
jason810496:fix/api-dag-cache-ttl-ignored

Conversation

@jason810496

@jason810496jason810496 commented Aug 19, 2026

Copy link
Copy Markdown
Member

[api] dag_cache_size = 0 reads as "no size limit", but it selected a mapping that never evicted and silently ignored [api] dag_cache_ttl. Age-based eviction could only be enabled by also accepting a size cap.

A TTL now applies with or without a size limit; only setting both options to 0 disables eviction. Deployments on dag_cache_size = 0 start evicting on the default hour-long TTL — set dag_cache_ttl = 0 to keep the old behaviour.

Also corrects the documented version_added for both options: 3.2.2, not 3.3.0.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

Generated-by: Claude Code (Opus 5) following the guidelines

@uranusjr

Copy link
Copy Markdown
Member

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated

@uranusjruranusjr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@jason810496
jason810496 marked this pull request as draft August 19, 2026 09:03
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
@jason810496
jason810496force-pushed the fix/api-dag-cache-ttl-ignored branch from a28d57e to 5f6c258CompareAugust 19, 2026 09:47
@jason810496
jason810496 requested a lite review from CopilotAugust 19, 2026 09:48

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
@jason810496
jason810496 marked this pull request as ready for review August 19, 2026 12:59

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a news fragment to the behavioral change when dag_cache_size = 0 since it’s visible to the user. The change is justified as a bug fix, but the fix may in turn cause issues in existing deployments.

Thanks TP for the review. I’ve resolved all the comments, and it makes sense to add the new fragment.

Comment threadairflow-core/docs/administration-and-deployment/web-stack.rst Outdated
Comment threadairflow-core/src/airflow/models/dagbag.py Outdated
@jason810496
jason810496 merged commit f63d321 into apache:mainAug 19, 2026
140 of 159 checks passed
pierrejeambrun pushed a commit that referenced this pull request Aug 27, 2026
…set (#71814) (#71845)
* Honor the API server Dag cache TTL when no size limit is set
`[api] dag_cache_size = 0` reads as "no size limit", but it selected a mapping
that never evicted at all and silently ignored `[api] dag_cache_ttl`. Age-based
eviction could therefore only be enabled by also accepting a size cap, which is
backwards for a deployment that wants to bound staleness rather than count.
A TTL now applies with or without a size limit, and only setting both options to
0 disables eviction. Deployments on `dag_cache_size = 0` start evicting on the
default hour-long TTL; setting `dag_cache_ttl = 0` restores the old behaviour.
The options were also documented as added in 3.3.0. They shipped in 3.2.2.
* Reject negative API Dag cache values and clarify TTL behavior
Negative cache configuration should fail fast, and operator guidance must reflect that TTL refreshes happen only at revalidation boundaries.
* Reject negative cache values for every DBDagBag caller
Validating at the shared boundary prevents non-API callers from silently clamping invalid cache settings.
* Clarify cache validation context and docs wording
Context-specific errors help operators identify invalid API settings, while defensive constructor checks protect other callers and documentation remains compatible with the spellchecker.
* Clarify API cache TTL documentation layout
(cherry picked from commit f63d321)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP APIarea:ConfigTemplatesarea:Schedulerincluding HA (high availability) schedulerkind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@uranusjr