Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 17.7k
Allow keeping PostgresHook SQLAlchemy engines on psycopg2#72000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sehajsandhu123
wants to merge
4
commits into
apache:mainChoose a base branch
from
sehajsandhu123:postgres-hook-sqlalchemy-scheme
base:main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+124
−2
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
67ff42e
Allow keeping PostgresHook SQLAlchemy engines on psycopg2
sehajsandhu123 2a45342
fix spellcheck errors
sehajsandhu123 858a07a
Add regression test for to_sql uuid inserts under psycopg3
sehajsandhu123 4f717de
Drop Postgres 7.0.0 changelog edit
sehajsandhu123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 28 additions & 2 deletions
30 providers/postgres/src/airflow/providers/postgres/hooks/postgres.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87 providers/postgres/tests/unit/postgres/hooks/test_postgres.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this should be an operator/hook parameter or something defined inside the Connection itself.
What was your thinking for putting it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashb It's primarily a connection property, the hook param is just an override on top. The intended usage is setting it once on the connection (or not setting it at all is also fine, for backwards compatibility) and the hook param only kicks in if explicitly passed.
The reason I added it is if most dags on a connection are fine on psycopg3 and only one or two break, it pins just those tasks instead of rolling the whole connection back to psycopg2. Keeps the opt-out small and lets the connection default move forward.
Happy to drop the hook param if you just want the connection extra.