Uh oh!
There was an error while loading. Please reload this page.
Reduce Iceberg snapshot watcher thread use - #72173
Merged
vincbeck merged 2 commits intoAug 28, 2026
Merged
Conversation
The trigger already runs on the event loop, so synchronous state access needlessly consumes worker threads and blocks async-only state stores. Signed-off-by: 1fanwang <1fannnw@gmail.com>
The previous wording still counted state-store calls as thread-pool work after the async migration. Signed-off-by: 1fanwang <1fannnw@gmail.com>
vincbeck
approved these changes
Aug 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each stateful Iceberg snapshot watcher submits worker-thread jobs to load and save its watermark. A triggerer running many watchers spends executor capacity on storage that already has an async API.
After this change, stateful watchers await watermark storage directly. Worker threads remain limited to synchronous PyIceberg catalog calls. Watchers without an injected state store keep their existing behavior.
Depends on #72127 and must merge after it.
Test output
Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI 1.0.80 (GPT-5.6 Sol) following the guidelines