Uh oh!
There was an error while loading. Please reload this page.
Support full downstream skip on LLM branch reject - #72183
Open
guan404ming wants to merge 1 commit into
Open
Conversation
guan404ming
marked this pull request as ready for review
August 29, 2026 02:09
guan404ming
requested review from
Lee-W, ashb, gopidesupavan and kaxil
as code ownersAugust 29, 2026 02:09
Rejecting a branch review only skipped the direct downstream tasks, so a task with a permissive trigger rule further down the chain still ran even though the reviewer had turned the branch down.
guan404mingforce-pushed
the
llm-branch-ignore-trigger-rules
branch
from
August 29, 2026 05:40
2bcd797 to
ddb6b4eCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
How
ignore_downstream_trigger_rulesto skip every downstream task on reject.This completes the alignment with
ApprovalOperatorstarted in #71073.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5) following the guidelines