[v3-3-test] Remove the unreachable 404 from the create Variable endpoint (#71245) by github-actions[bot] · Pull Request #72190 · apache/airflow

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actions · 2026-08-28T08:52:47Z

The branch guards a read-back of the row Variable.set() upserted moments earlier
through the same session, so it cannot be reached. It exists only to narrow a type:
SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what
convinces mypy the value is not None.

Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells
a caller the variable they just created was not found, which left the endpoint
choosing between publishing a response it can never return and leaving its spec
incomplete. Asking the session for exactly one row states the same invariant where
it belongs — in the query — so neither control flow nor a status code is needed to
express it.
(cherry picked from commit 6171e2b)

Co-authored-by: Jyun-An Chen jun930436@gmail.com

…int (#71245) The branch guards a read-back of the row Variable.set() upserted moments earlier through the same session, so it cannot be reached. It exists only to narrow a type: SQLAlchemy 2 declares Session.scalar() as returning Optional, and a raise is what convinces mypy the value is not None. Paying for that with an HTTP status is the problem. A 404 on a create endpoint tells a caller the variable they just created was not found, which left the endpoint choosing between publishing a response it can never return and leaving its spec incomplete. Asking the session for exactly one row states the same invariant where it belongs — in the query — so neither control flow nor a status code is needed to express it. (cherry picked from commit 6171e2b) Co-authored-by: Jyun-An Chen <jun930436@gmail.com>

github-actions · 2026-08-28T12:48:17Z

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.3.2 based on: merged to version branch
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot mentioned this pull request Aug 28, 2026
Remove the unreachable 404 from the create Variable endpoint #71245
Merged

boring-cyborgBot added the area:API Airflow's REST/HTTP API label Aug 28, 2026

pierrejeambrun marked this pull request as ready for review August 28, 2026 09:04

pierrejeambrun requested review from bugraoz93, choo121600, ephraimbuddy, henry3260, jason810496, pierrejeambrun, rawwar and shubhamraj-git as code owners August 28, 2026 09:04

henry3260 approved these changes Aug 28, 2026
View reviewed changes

vincbeck approved these changes Aug 28, 2026
View reviewed changes

vincbeck merged commit 3610b80 into v3-3-testAug 28, 2026
97 of 98 checks passed

vincbeck deleted the backport-6171e2b-v3-3-test branch August 28, 2026 12:47

github-actionsBot added this to the Airflow 3.3.2 milestone Aug 28, 2026