Uh oh!
There was an error while loading. Please reload this page.
[AMORO-4359][AMS] Support AWS Secrets Manager as a ConfigShade - #4360
Open
wangxianghu wants to merge 1 commit into
Open
[AMORO-4359][AMS] Support AWS Secrets Manager as a ConfigShade#4360wangxianghu wants to merge 1 commit into
wangxianghu wants to merge 1 commit into
Conversation
wangxianghuforce-pushed
the
aws-sm-config-shade
branch
2 times, most recently
from
September 4, 2026 23:29
3d81103 to
98de4eeComparewangxianghuforce-pushed
the
aws-sm-config-shade
branch
from
September 5, 2026 00:00
e22116b to
fa2ba56Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close#4359.
AMS keeps sensitive values such as
admin-passwordanddatabase.passwordinconfig.yaml. Today the only shade providers arebase64and the built-indefault, so operators still have to store the real secret (obfuscated at best) on disk. When AMS runs on AWS, the natural place for these secrets is AWS Secrets
Manager, with credentials resolved from the environment (EKS IRSA, ECS/EC2
instance profile, etc.) rather than checked into a file.
This PR adds an
aws-smConfigShadeimplementation so that a sensitive configvalue can be an AWS Secrets Manager ARN, and AMS resolves the real value at
startup:
omit it when the secret value is the plaintext itself.
starts with a wrong secret.
Brief change log
ARN into its value, extracting a JSON field when # is given.
extracting the region from the ARN.
testable wrapper over the AWS SDK using the URL-connection HTTP client (no
Netty), the default credentials provider chain, and per-process caching.
expected to be in one region, and a cross-region reference fails fast.
url-connection-client dependencies.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Added TestSecretReference (ARN/region/#field parsing, whitespace, and
every malformed-input rejection) and TestAwsSecretsManagerConfigShade
(plaintext vs JSON-field decryption, dotted field names taken literally rather
than as a nested path, client memoization, cross-region fail-fast, and the
invalid-JSON / missing-field / malformed-ARN failure paths) — 23 tests, all
passing.
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation