Skip to content

Update AntClassLoader.java - #112

Open
majkelBB wants to merge 1 commit into
apache:masterfrom
majkelBB:patch-1
Open

Update AntClassLoader.java#112
majkelBB wants to merge 1 commit into
apache:masterfrom
majkelBB:patch-1

Conversation

@majkelBB

Copy link
Copy Markdown

Shouldn't usage of pathComponents be threadsafe here and in other places where code iterates over pathComponents?

Shouldn't usage of pathComponents be threadsafe here and in other places where code iterates over pathComponents?
@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

1 similar comment
@asf-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@jaikiran

Copy link
Copy Markdown
Member

this is ok to test

@asf-ci

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/147/

@asf-ci

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/153/

@bodewig

Copy link
Copy Markdown
Member

The way AntClassLoader wants to be used (and is used inside of Ant's codebase) is a single-threaded setup phase followed by potentially multithreaded use of if where its setup is no longer changed.

Personally I'd rather document this than try to sprinkle in a few synchronizeds.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@majkelBB@asf-ci@jaikiran@bodewig