Skip to content

Update the optional dependencies - #138

Open
twogee wants to merge 3 commits into
apache:masterfrom
twogee:fresh-dependencies
Open

Update the optional dependencies#138
twogee wants to merge 3 commits into
apache:masterfrom
twogee:fresh-dependencies

Conversation

@twogee

Copy link
Copy Markdown
Contributor

No description provided.

@twogee
twogeeforce-pushed the fresh-dependencies branch 2 times, most recently from de1d02f to 1ee6231CompareMarch 6, 2021 19:19
@twogee
twogeeforce-pushed the fresh-dependencies branch from 1ee6231 to 6de7231CompareMarch 14, 2021 22:04
@twogee
twogeeforce-pushed the fresh-dependencies branch from 6de7231 to 3c9add2CompareJune 8, 2021 06:49
@twogee
twogeeforce-pushed the fresh-dependencies branch from 3c9add2 to 7d1cd33CompareJuly 18, 2021 13:20
@bodewig

Copy link
Copy Markdown
Member

@twogee the switch to jakarta.mail is not backwards compatible. I don't think we can do it that way at all. Rather we'll need to introduce a new type of Mailer and an additional jar with different dependencies, I'm afraid.

@twogee
twogeeforce-pushed the fresh-dependencies branch from 7d1cd33 to 7b26711CompareOctober 2, 2021 04:40
@bodewig

Copy link
Copy Markdown
Member

Thank you @twogee - do you think you could split the Jakarta Mailer support changes from the other changes?

The changes to ClasspathUtils seem to be completely unrelated to either and the chunk that removes string concatenation is completely unnecessary anyway.

@twogee

Copy link
Copy Markdown
ContributorAuthor

Thanks, @bodewig, and sorry about missing the extraneous changes.
I will open a new PR for changes re Jakarta Mail specifically.
The change to ClasspathUtils is related to an attempt to avoid nested try in EmailTask#getMailerImplementation().

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@twogee@bodewig