Uh oh!
There was an error while loading. Please reload this page.
refactor(rust/core): moved adbc traits to sync mod - #3932
Conversation
Signed-off-by: if0ne <pavel.agafonov.al@gmail.com>
if0ne
commented
Jan 30, 2026
СС @lidavidm |
lidavidm
commented
Jan 30, 2026
While I'm not opposed to breaking changes, I still feel it would be least disruptive to have the async traits in their own (new) module, rather than the sync traits |
lidavidm
commented
Jan 30, 2026
Or is this just to clean up |
if0ne
commented
Jan 30, 2026
Clean up |
lidavidm
commented
Feb 4, 2026
@felipecrv@eitsupi any concerns? |
eitsupi
commented
Feb 4, 2026
There doesn't seem to be any problem with this movement 🚀 |
felipecrv
commented
Feb 4, 2026
I would prefer |
lidavidm
commented
Feb 5, 2026
Right, this doesn't change anything, since the submodule's contents are re-exported. I do think that even when we add async traits, those should not be at the crate root but should be namespaced (and we can keep sync as the default). |
Uh oh!
There was an error while loading. Please reload this page.
A small step toward implementing #3714