Uh oh!
There was an error while loading. Please reload this page.
feat!(go): split Flight SQL into its own module - #4754
Open
lidavidm wants to merge 1 commit into
Open
Conversation
lidavidmforce-pushed
the
gh-4623
branch
5 times, most recently
from
September 4, 2026 04:53
6d3aec9 to
ed14bd0CompareThis way we don't leak CVEs/dependencies from the driver into the core ADBC package. Breaking changes: - package go/adbc/driver/flightsql => go/flightsql - package go/adbc/sqldriver/flightsql => go/flightsql/sqldriver Also, `driverbase` is now exposed. Closesapache#4623.
MemberAuthor
I wonder if I should just move driverbase to be part of flightsql (since we don't really expect to export it anyways) to get the OpenTelemetry dependency out of core, or even use the thirdparty driverbase fork |
zeroshade
commented
Sep 4, 2026
Member
I think that's fine since we have we have https://github.com/adbc-drivers/driverbase-go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we don't leak CVEs/dependencies from the driver into the core ADBC package.
Breaking changes:
Also,
driverbaseis now exposed.TODOs
Closes#4623.