Skip to content

GH-5: [Docs] Add LICENSE and NOTICE files - #39

Merged
kou merged 7 commits into
apache:mainfrom
raulcd:GH-5
Nov 29, 2024
Merged

GH-5: [Docs] Add LICENSE and NOTICE files#39
kou merged 7 commits into
apache:mainfrom
raulcd:GH-5

Conversation

@raulcd

@raulcdraulcd commented Nov 26, 2024

Copy link
Copy Markdown
Member

Closes#5

@raulcd

raulcd commented Nov 26, 2024

Copy link
Copy Markdown
MemberAuthor

I've trimmed down and removed all dependencies that seem to refer to C++ / Python / and other implementations and left the ones that are related to Java (or seem to be related to Java).

@raulcd
raulcd marked this pull request as ready for review November 26, 2024 14:32
kou
kou reviewed Nov 27, 2024
View reviewed changes
Comment threadNOTICE.txt Outdated
kou
kou reviewed Nov 28, 2024
View reviewed changes
Comment threadLICENSE.txt Outdated
Comment threadLICENSE.txt
Comment threadLICENSE.txt Outdated
Comment on lines +211 to +216
--------------------------------------------------------------------------------

This product includes software from Dremio, which is made available under the
Apache License 2.0.
* Copyright (C) 2017-2018 Dremio Corporation
* https://github.com/dremio/dremio-oss

@koukouNov 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we can remove this because we removed "Copyright (C) 2017-2018 Dremio Corporation" by apache/arrow#5602 .
Anyway, I should have asked why we can remove it when I merge...

@raulcdraulcdNov 28, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kou ! I've removed it

@raulcd

raulcd commented Nov 28, 2024

Copy link
Copy Markdown
MemberAuthor

I've rebased main but it seems pre-commit is failing there. I've opened:

kou
kou reviewed Nov 29, 2024
View reviewed changes
Comment threadLICENSE.txt Outdated
kou
kou approved these changes Nov 29, 2024
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 55fced5 into apache:mainNov 29, 2024
@lidavidmlidavidm added this to the 18.2.0 milestone Jan 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes
@assignUserassignUserassignUser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.2.0

Development

Successfully merging this pull request may close these issues.

Add LICENSE.txt and NOTICE

4 participants

@raulcd@kou@assignUser@lidavidm