Skip to content

GH-7: Add macOS, Windows CI - #432

Merged
kou merged 10 commits into
apache:mainfrom
lidavidm:gh-7
Nov 29, 2024
Merged

GH-7: Add macOS, Windows CI#432
kou merged 10 commits into
apache:mainfrom
lidavidm:gh-7

Conversation

@lidavidm

Copy link
Copy Markdown
Member

Fixes#7.
Fixes#8.

@lidavidm

Copy link
Copy Markdown
MemberAuthor

Hmm, macOS realpath is not as capable

@lidavidm
lidavidm marked this pull request as ready for review November 28, 2024 03:12

@raulcdraulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing but all the rest looks good to me

Comment thread.github/workflows/test.yml Outdated
- arch: AArch64
jdk: 11
macos: latest
include:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I missed that :)

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, tests all pass

kou
kou approved these changes Nov 29, 2024

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 8f8c62f into apache:mainNov 29, 2024
@lidavidm
lidavidm deleted the gh-7 branch November 29, 2024 01:00
@lidavidmlidavidm added this to the 18.2.0 milestone Jan 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test CI: Windows Add test CI: macOS

3 participants

@lidavidm@kou@raulcd