Uh oh!
There was an error while loading. Please reload this page.
GH-10: Add basic checks into pre-commit-config - #435
Merged
Conversation
kou
commented
Dec 1, 2024
Member
Could you add https://github.com/apache/arrow-go/blob/main/.editorconfig for shfmt? |
kiszk
commented
Dec 1, 2024
MemberAuthor
Good catch, thank you. |
kou
reviewed
Dec 2, 2024
Uh oh!
There was an error while loading. Please reload this page.
kiszk
marked this pull request as ready for review
December 4, 2024 18:05
kiszk
marked this pull request as draft
December 4, 2024 19:22
lidavidm
left a comment
Member
There was a problem hiding this comment.
Do we want to revert the YAML changes since we aren't using yamlfmt?
kiszk
commented
Dec 12, 2024
MemberAuthor
I see. I thought the reformatting of indentation made sense. |
kiszk
commented
Dec 23, 2024
MemberAuthor
Reverted changes in YAML files |
lidavidm
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#10
Fixes#11
Removed gh 12 now