Skip to content

MINOR: Add explicit exception when no more buffer can be read when loading buffers - #649

Merged
viirya merged 1 commit into
apache:mainfrom
viirya:improve_error
Mar 4, 2025
Merged

MINOR: Add explicit exception when no more buffer can be read when loading buffers#649
viirya merged 1 commit into
apache:mainfrom
viirya:improve_error

Conversation

@viirya

Copy link
Copy Markdown
Member

What's Changed

When VectorLoader tries to load buffers (i.e., loadBuffers), it has detect on the error case that some buffers are not consumed. But another error that the number of buffers is less than expected is not handled for now. Once it is happened, users will get java.util.NoSuchElementException which is not easy to understand.

This patch adds an explicit exception for such case.

See more discussion at #648.

@github-actions

This comment has been minimized.

@lidavidmlidavidm added the enhancement PRs that add or improve features. label Mar 4, 2025
@viirya

Copy link
Copy Markdown
MemberAuthor
This request has been automatically failed because it uses a deprecated version of `actions/cache: 6849a6489940f00c2f30c0fb92c6274307ccb58a`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. 

Seems CI has some issues? I may not be able to handle it for now. Leave it to others or I can take a look tomorrow. Thanks.

@jbonofre

Copy link
Copy Markdown
Member

FYI, I'm working on a PR about GitHub Action. It will be available soon and this PR can be rebase after the merge of my PR.

@viirya

Copy link
Copy Markdown
MemberAuthor

FYI, I'm working on a PR about GitHub Action. It will be available soon and this PR can be rebase after the merge of my PR.

Thank you @jbonofre

@jbonofre

Copy link
Copy Markdown
Member

See #650

@viirya

Copy link
Copy Markdown
MemberAuthor

Rebased.

@viirya

Copy link
Copy Markdown
MemberAuthor

Thanks @lidavidm@jbonofre

One question. How do you merge PRs in this repo? Just use merge button or there is a script for it?

@jbonofre

Copy link
Copy Markdown
Member

@viirya we are using "merge button", but only committers/PMC members can do that.

@viirya
viirya merged commit 5e71a2a into apache:mainMar 4, 2025
@viirya

Copy link
Copy Markdown
MemberAuthor

Thank you @jbonofre. I merged this.

@viirya
viirya deleted the improve_error branch March 4, 2025 17:43
@lidavidmlidavidm added this to the 18.3.0 milestone Mar 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementPRs that add or improve features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@viirya@jbonofre@lidavidm