Skip to content

GH-709: Correct length calculation of value buffers of variable-sized arrays#707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Apr 14, 2025
Merged

GH-709: Correct length calculation of value buffers of variable-sized arrays #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions c/src/main/java/org/apache/arrow/c/BufferImportTypeVisitor.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -228,9 +228,8 @@ public List<ArrowBuf> visit(ArrowType.Utf8 type) {
type,
start,
end);
final int len = end - start;
offsets.getReferenceManager().retain();
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, len));
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, end));
}
}

Expand DownExpand Up@@ -279,9 +278,8 @@ public List<ArrowBuf> visit(ArrowType.LargeUtf8 type) {
type,
start,
end);
final long len = end - start;
offsets.getReferenceManager().retain();
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, len));
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, end));
}
}

Expand All@@ -296,9 +294,8 @@ public List<ArrowBuf> visit(ArrowType.Binary type) {
type,
start,
end);
final int len = end - start;
offsets.getReferenceManager().retain();
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, len));
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, end));
}
}

Expand All@@ -320,9 +317,8 @@ public List<ArrowBuf> visit(ArrowType.LargeBinary type) {
type,
start,
end);
final long len = end - start;
offsets.getReferenceManager().retain();
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, len));
return Arrays.asList(maybeImportBitmap(type), offsets, importData(type, end));
}
}

Expand Down