Uh oh!
There was an error while loading. Please reload this page.
MINOR: Bump version to 18.3.0 - #741
Conversation
This comment has been minimized.
This comment has been minimized.
jbonofre
commented
May 9, 2025
That's not correct. It should be SNAPSHOT version as the release is done by the maven-release-plugin. |
kou
left a comment
There was a problem hiding this comment.
+1
This is correct.
We don't create a release branch. We release a RC from main. So we should use no -SNAPSHOT version here.
kou
commented
May 9, 2025
FYI: We don't use maven-release-plugin for our release. |
kou
commented
May 9, 2025
Ah, sorry. We use maven-release-plugin. https://github.com/apache/arrow-java/blob/main/dev/release/bump_version.sh that creates this PR uses maven-release-plugin. |
jbonofre
commented
May 9, 2025
Yea AFAIR we use the maven plugin in the release script. |
kou
commented
May 9, 2025
Do you still think we need |
wgtmac
commented
May 9, 2025
I think it is fine. The caveat is that the main branch must be kept unchanged until the release is done. |
kou
commented
May 9, 2025
Right. It's a restriction of the current release process. |
wgtmac
commented
May 9, 2025
Are you good with this PR? @jbonofre |
jbonofre
left a comment
There was a problem hiding this comment.
Ok as soon as the version is bumped to SNAPSHOT after the release
wgtmac
commented
May 9, 2025
Thanks! Let me merge it and proceed. |
No description provided.