Uh oh!
There was an error while loading. Please reload this page.
GH-399: Check for null writers in DenseUnionWriter#setPosition - #938
Merged
lidavidm merged 3 commits intoDec 29, 2025
Merged
Conversation
Added null checks for setPosition and test cases to validate the issue
Kaustav-Sarkar
requested review from
jbonofre, laurentgo, lidavidm and wgtmac
as code ownersDecember 24, 2025 16:27
This comment has been minimized.
This comment has been minimized.
Kaustav-Sarkar
commented
Dec 24, 2025
ContributorAuthor
I do not have permissions to set labels |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lidavidm
commented
Dec 29, 2025
Member
Ok. The JNI test is an upstream build issue, but @Kaustav-Sarkar can you fix the format error in .gitignore? https://github.com/apache/arrow-java/actions/runs/20526378098/job/59055944634?pr=938 |
Uh oh!
There was an error while loading. Please reload this page.
ennuite pushed a commit
to ennuite/arrow-java
that referenced
this pull request
Jan 8, 2026
…pache#938) ## apacheGH-399 Fix setPosition fails with NullPointerException Fixed a `NullPointerException` in `DenseUnionWriter#setPosition`. The issue was that `setPosition` tried to update all writers in its internal array, even if they hadn't been initialized yet. I added a null check so it only updates writers that actually exist. Also added a regression test (`TestDenseUnionWriterNPE`) to verify the fix and updated `.gitignore`. Closesapache#399.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-399 Fix setPosition fails with NullPointerException
Fixed a
NullPointerExceptioninDenseUnionWriter#setPosition.The issue was that
setPositiontried to update all writers in its internal array, even if they hadn't been initialized yet. I added a null check so it only updates writers that actually exist.Also added a regression test (
TestDenseUnionWriterNPE) to verify the fix and updated.gitignore.Closes#399.