Skip to content

GH-125: Allow null timestamp holder sans timezone - #941

Merged
jbonofre merged 3 commits into
apache:mainfrom
Kaustav-Sarkar:GH-125
Jan 22, 2026
Merged

GH-125: Allow null timestamp holder sans timezone#941
jbonofre merged 3 commits into
apache:mainfrom
Kaustav-Sarkar:GH-125

Conversation

@Kaustav-Sarkar

Copy link
Copy Markdown
Contributor

Description

Fixes an IllegalArgumentException in TimeStamp*TZVector.set/setSafe when unsetting values using a holder with a null timezone. The validation logic now correctly ignores the timezone check when holder.isSet <= 0, allowing default-constructed holders to be used for unsetting values as expected.

Comprehensive tests added for all timestamp precisions (Micro, Milli, Nano, Sec) to verify the fix and ensure the existing workaround (setting explicit timezone) remains supported.

Closes#125 .

@github-actions

This comment has been minimized.

@Kaustav-Sarkar

Copy link
Copy Markdown
ContributorAuthor

Please set labels, I do not have permission

@lidavidmlidavidm changed the title GH-125: Fix Timestamp unset bugGH-125: Allow setting null timestamp holder sans timezoneDec 30, 2025
@lidavidmlidavidm changed the title GH-125: Allow setting null timestamp holder sans timezoneGH-125: Allow null timestamp holder sans timezoneDec 30, 2025
@lidavidmlidavidm added the bug-fix PRs that fix a big. label Dec 30, 2025
@github-actionsgithub-actionsBot added this to the 18.4.0 milestone Dec 30, 2025
@Kaustav-Sarkar

Kaustav-Sarkar commented Dec 30, 2025

Copy link
Copy Markdown
ContributorAuthor
Could not find a package configuration file provided by "lz4" with any of
the following names:
lz4Config.cmake
lz4-config.cmake
Add the installation prefix of "lz4" to CMAKE_PREFIX_PATH or set "lz4_DIR"
to a directory containing one of the above files. If "lz4" provides a
separate development package or SDK, be sure it has been installed.

The build fails with this issue, I do not see how it is related to my changes. Do I need to add anything else to get this PR merged?
@lidavidm@jbonofre

@jbonofre

Copy link
Copy Markdown
Member

@Kaustav-Sarkar do you mind to rebase ? It should fix the CI. Thanks !

@Kaustav-Sarkar

Copy link
Copy Markdown
ContributorAuthor

I have rebased it @jbonofre

@jbonofre
jbonofre merged commit ccaac9a into apache:mainJan 22, 2026
46 of 48 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fixPRs that fix a big.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] IllegalArgumentException when unsetting TimeStamp*TZVector values

3 participants

@Kaustav-Sarkar@jbonofre@lidavidm