Skip to content

MINOR: Add private constructor to UuidType singleton - #945

Merged
jbonofre merged 3 commits into
apache:mainfrom
tmater:uuidtype_singleton
Jan 9, 2026
Merged

MINOR: Add private constructor to UuidType singleton#945
jbonofre merged 3 commits into
apache:mainfrom
tmater:uuidtype_singleton

Conversation

@tmater

Copy link
Copy Markdown
Contributor

Add private constructor to UuidType singleton.

@github-actions

This comment has been minimized.

@lidavidmlidavidm added bug-fix PRs that fix a big. labels Jan 6, 2026
@github-actionsgithub-actionsBot added this to the 18.4.0 milestone Jan 6, 2026

@lidavidmlidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds fail:

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project arrow-vector: Compilation failure: Compilation failure: Error: /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[72,52] error: UuidType() has private access in UuidType
Error: /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[102,52] error: UuidType() has private access in UuidType

@tmater

Copy link
Copy Markdown
ContributorAuthor

All builds fail:

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:compile (default-compile) on project arrow-vector: Compilation failure: Compilation failure: Error: /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[72,52] error: UuidType() has private access in UuidType
Error: /build/vector/src/main/java/org/apache/arrow/vector/UuidVector.java:[102,52] error: UuidType() has private access in UuidType

Thank you for looking into it @lidavidm.
I thought I ran a local build 😅.
Fully updated the UuidType usage.

@jhrotkojhrotko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lidavidmlidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let JB handle merging

@jbonofrejbonofre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you mind to rebase in order to have CI happy ?

@tmater
tmaterforce-pushed the uuidtype_singleton branch from 530d5a8 to cd32ddbCompareJanuary 9, 2026 08:27
@tmater

tmater commented Jan 9, 2026

Copy link
Copy Markdown
ContributorAuthor

LGTM.

Do you mind to rebase in order to have CI happy ?

Thank you for the review!
Not at all, rebased.

@jbonofre

Copy link
Copy Markdown
Member

@tmater thanks ! I just ran the CI, I will merge as soon as it's all green.

@jbonofre

Copy link
Copy Markdown
Member

@tmater I see failure in RoundStripTest:

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:testCompile (default-testCompile) on project arrow-c-data: Compilation failure: Compilation failure: Error: /build/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:[813,43] error: cannot find symbol
Error: symbol: variable INSTANCE
Error: location: class UuidType

@tmater

tmater commented Jan 9, 2026

Copy link
Copy Markdown
ContributorAuthor

@tmater I see failure in RoundStripTest:

Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.0:testCompile (default-testCompile) on project arrow-c-data: Compilation failure: Compilation failure: Error: /build/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:[813,43] error: cannot find symbol
Error: symbol: variable INSTANCE
Error: location: class UuidType

Interesting, there was a UuidType/UuidVector implementation in RoundStripTest. Removed it.

@jbonofre
jbonofre merged commit bd3a6ee into apache:mainJan 9, 2026
26 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fixPRs that fix a big.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tmater@jbonofre@lidavidm@jhrotko