Uh oh!
There was an error while loading. Please reload this page.
add isbitstype optimized path for FixedSizeList getindex - #104
Conversation
Codecov Report
@@ Coverage Diff @@## main #104 +/- ##
==========================================
- Coverage 84.48% 84.06% -0.43%
==========================================
Files 22 23 +1 Lines 2611 2692 +81 ==========================================
+ Hits 2206 2263 +57 - Misses 405 429 +24
Continue to review full report at Codecov.
|
b7bb22d to
239bdcaComparejrevels
commented
Jan 9, 2021
Using the same Still slower than the Once either #103 or this PR is merged, the remaining PR should be refactored to use the same underlying |
239bdca to
2d8b8d8Comparejrevels
commented
Jan 12, 2021
done! |
* add isbitstype optimized path for FixedSizeList getindex * reuse _unsafe_cast strategy from apache#103 * rebase + DRY _unsafe_cast
ref #103 (comment)
#103 before this PR:
#103 after this PR:
Order of magnitude improvement + allocations/memory now on par with pre-#103 behavior. Nice!
Still an order of magnitude of runtime perf on the table compared to the equivalent
Primitivethough. will play around and check whether branching changes/direct pointer manipulation might recover some of that.