Uh oh!
There was an error while loading. Please reload this page.
migrate ArrowTypes code that depends on Sockets and UUIDs to extensions - #500
migrate ArrowTypes code that depends on Sockets and UUIDs to extensions#500baumgold wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #500 +/- ##
==========================================
- Coverage 87.34% 87.25% -0.10%
==========================================
Files 26 28 +2 Lines 3288 3280 -8 ==========================================
- Hits 2872 2862 -10 - Misses 416 418 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ericphanson
commented
Feb 8, 2024
What happens if a table was serialized with one of these objects, but now you're loading it in a session in which e.g. UUIDs isn't loaded? I think this is probably breaking, unfortunately, since before you'd get back UUID types, whereas now you have to change your code to load UUIDs to get it. |
baumgold
commented
Feb 8, 2024
That's a valid point, thanks for bringing it up. Do you think it's worth continuing with this change but bump major rather than minor? Or should we abandon this change for now? |
ericphanson
commented
Feb 8, 2024
These are pretty light packages, and are in the sysimage anyway until v1.11, so to me it doesn’t feel worth all the compat bumps it will cause. I think it’s worth waiting until there’s other reasons for a breaking change, or some big reason why having them is causing problems. |
baumgold
commented
Feb 9, 2024
Sounds good. I'll put this PR on hold for now. Thanks for the feedback. |
| [compat] | ||
| julia = "1.0" | ||
| julia = "1.9" |
There was a problem hiding this comment.
Why not keep the existing Julia version compat and do this instead? https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension
Also add support for
Sockets.InetAddr