Skip to content

[C++][Compute] Consider removing ScalarAggregateKernel #29116

Description

@asfimport

Scalar aggregation does not incur large memory overhead for the associated KernelState objects, so maybe it'd be acceptable to remove explicit scalar aggregation kernels in favor of reusing grouped aggregation kernels with a single group. This would decrease our maintenance burden significantly, and if the benchmarks don't show a regression for single-group aggregation then there's no reason not to.

Even if there is a performance regression we could bundle the scalar and grouped aggregate kernels in the same compute::Function and decide between them in Dispatch*, rather than confusingly defining distinct "sum" and "hash_sum" functions

Reporter: Ben Kietzman / @bkietz

PRs and other links:

Note: This issue was originally created as ARROW-13451. Please see the migration documentation for further details.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions