[R] Aggregation on expression doesn't NSE correctly

[asfimport]

 expect_dplyr_equal(
 input %>%
 mutate(has_words = nchar(verses) < 0) %>%
 group_by(some_grouping) %>%
 summarize(all(has_words)) %>%
 arrange(some_grouping) %>%
 collect(),
 tbl
 )

works, but if you define the expression inline, it doesn't:

 expect_dplyr_equal(
 input %>%
 group_by(some_grouping) %>%
 summarize(has_words = all(nchar(verses) < 0)) %>%
 arrange(some_grouping) %>%
 collect(),
 tbl
 )

The error you get I think means that base::nchar is being called. I'm not sure if this is a general issue with our nse_funcs calling other nse_funcs, or if this is about the way the aggregation function environment is constructed separately, but it's not good.

Reporter: Neal Richardson / @nealrichardson
Assignee: Neal Richardson / @nealrichardson

Related issues:

• [R] Use Arrow engine for summarize() by default (blocks)
• [R] Initial bindings for ExecPlan/ExecNode (relates to)

PRs and other links:

• GitHub Pull Request #10938

_{Note: This issue was originally created as ARROW-13499. Please see the migration documentation for further details.}

[asfimport]

Ian Cook / @ianmcook:
I noticed another strange NSE behavior inside summarise(): in aggregate functions, if you pass na.rm as shorthand T or F instead of TRUE or FALSE, you get an error like this:

Error: Can't subset columns that don't exist.
x Column `T` doesn't exist.

[asfimport]

Neal Richardson / @nealrichardson:
Issue resolved by pull request 10938
#10938