Skip to content

[R] [CI] Clean up our snappy-sanitizer skipping behavior #31766

Description

@asfimport

We have a number of locations where we skip parquet tests now that snappy is built by default + we use it by default when it is built.

One recent example of needing to do this is #13014

However, skipping tests like this is a little bit of misdirection, since we aren't really skipping these because | when snappy is not available like the helper suggests, just using that helper to also skip when we know we are in a sanitizer environment.

The ultimate answer to this, of course is to upstream the change google/snappy#148 though that's been sitting open for a few months still.

In the meantime, what if we took out these skips and instead used uncompressed parquet for reading and writting in some builds? This way we could make sure that snappy was not running during sanitizer tests, but still have test coverage for these code paths in other runs where we don't need to worry about this sanitizer error in snappy.

#13014 (comment) proposed one way to do this in this one case, but we should do it more generally for the other skips that we have had to add.

Reporter: Jonathan Keane / @jonkeane

Related issues:

Note: This issue was originally created as ARROW-16385. Please see the migration documentation for further details.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions