Skip to content

[C++] Document the guarantees of ChunkResolver::Resolve and minimize branching #39815

Description

@felipecrv

Describe the enhancement requested

The invariants of ChunkResolver and pre-conditions of ChunkResolver::Resolve() are unclear which can lead to multiple problems:

  1. Misuse
  2. Misunderstanding that leads to addition of more checks that can kill speculative execution in tight loops
  3. Missed micro-optmization opportunities

Request: document the class and implement possible micro-optmizations.

Component(s)

C++

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions