[C++] DCHECK macros conflicts with glog

[irshadcc]

Describe the bug, including details regarding any error messages, version, and platform.

The DCHECK macros in logging.h are conflicting with glog's macro definition. This often causes compilation problems in the downstream dependencies.

DCHECKs in glog : https://github.com/google/glog/blob/master/src/glog/logging.h#L1081
DCHECKs in arrow : https://github.com/apache/arrow/blob/main/cpp/src/arrow/util/logging.h#L142

Component(s)

C++

[kou]

You are including glog headers after including Apache Arrow, right?

[irshadcc]

Yes. There are glog includes in my dependencies which makes it hard to solve

[kou]

#46015 hides these macros but here is a workaround:

#include <arrow/util/logging.h>
#include <glog/logging.h>

#include <your dependency>

[irshadcc]

Yes, this is a workaround. I have also come up with this solution. In order to do this, I have to change the includes of all my source files

[kou]

Issue resolved by pull request 46015
#46015

[irshadcc]

May I ask why we still want to use DCHECK inside the cpp files ?

The best convention followed by C++ developers is to avoid conflicting declarations by adding prefix. For macros, we can use ARROW_ as the prefix.

[kou]

Because it's shorter than ARROW_DCHECK*. In general, (reasonable) shorter names are easier to write and read.