Skip to content

[C++][Compute] Possible discarded bad status in expression bind #47268

Description

@zanmato1984

Describe the bug, including details regarding any error messages, version, and platform.

// First try and bind exactly
Result<const Kernel*> maybe_exact_match = call.function->DispatchExact(types);
if (maybe_exact_match.ok()) {
call.kernel = *maybe_exact_match;
if (FinishBind().ok()) {
returnExpression(std::move(call));
}
}
if (!insert_implicit_casts) {
return maybe_exact_match.status();
}

In L569 we only handle the ok case for FinishBind(). If not ok, and insert_implicit_casts is false, we'll return maybe_exact_match.status() instead of the real (bad) one of FinishBind().

Component(s)

C++

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions