Skip to content

[C++] Reuse abstraction for null partitions in sorting functions #50247

Description

@taepper

Describe the enhancement requested

#46926 introduced helper functions which partition a set of indices into three spans for null, nan and non_null_like. @pitrou mentioned the follow-up of consolidating these methods with other partitioning methods in vector_sort_internal.h as it can be confusing to have the same abstraction in the codebase twice.

The current NullPartitionResult structure only distinguished between null and non_null. This limitation is circumvented by storing two partition results, with the additional one distinguishing nan and non_null_like. This workaround should be removed by reusing the new PartitionResultByNullLikeness

Component(s)

C++

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions