Skip to content

ARROW-12400: [Rust] Re-enable tests in arrow::array::transform - #10048

Closed
tustvold wants to merge 1 commit into
apache:masterfrom
tustvold:enable-transform-tests
Closed

ARROW-12400: [Rust] Re-enable tests in arrow::array::transform#10048
tustvold wants to merge 1 commit into
apache:masterfrom
tustvold:enable-transform-tests

Conversation

@tustvold

Copy link
Copy Markdown
Contributor

These tests were all commented out in #9329. Given the PR made changes to the commented out code, I'm inclined to think this was an accidental omission? If not, happy for this to be closed 😀

FYI @jorgecarleitao

Signed-off-by: Raphael Taylor-Davies r.taylordavies@googlemail.com

Signed-off-by: Raphael Taylor-Davies <r.taylordavies@googlemail.com>

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold

@tustvoldtustvold changed the title ARROW-12400: Re-enable tests in arrow::array::transformARROW-12400: [Rust] Re-enable tests in arrow::array::transformApr 15, 2021

@jorgecarleitaojorgecarleitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @tustvold 👍

@github-actions

Copy link
Copy Markdown

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #10048 (3d3f407) into master (26a5a04) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24% 
==========================================
Files 286 286 Lines 64213 64664 +451 ==========================================
+ Hits 50538 51054 +516 + Misses 13675 13610 -65 
Impacted FilesCoverage Δ
rust/arrow/src/array/transform/mod.rs93.20% <100.00%> (+22.96%)⬆️
rust/parquet/src/encodings/encoding.rs95.05% <0.00%> (+0.19%)⬆️
rust/arrow/src/array/equal/mod.rs93.58% <0.00%> (+0.34%)⬆️
rust/arrow/src/array/data.rs78.37% <0.00%> (+1.50%)⬆️
rust/arrow/src/array/array_binary.rs89.86% <0.00%> (+3.80%)⬆️
rust/arrow/src/array/transform/variable_size.rs100.00% <0.00%> (+12.12%)⬆️
rust/arrow/src/array/transform/primitive.rs100.00% <0.00%> (+28.57%)⬆️
rust/arrow/src/array/transform/structure.rs83.33% <0.00%> (+38.88%)⬆️
rust/arrow/src/array/transform/null.rs66.66% <0.00%> (+66.66%)⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c394a20...3d3f407. Read the comment docs.

@kszucs

Copy link
Copy Markdown
Member

@andygrove I assume we'd like to have it in the release.

@alamb

Copy link
Copy Markdown
Contributor

@andygrove I assume we'd like to have it in the release.

FWIW @kszucs I don't think this is something that we should hold the release for -- it does not have any change to the actual code, only the tests.

@kszucs

Copy link
Copy Markdown
Member

Ok, thought that implementation was affected as well. I'm still waiting for other PRs so feel free to merge on green.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (26a5a04) to head (3d3f407).

Additional details and impacted files
@@ Coverage Diff @@## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24% 
==========================================
Files 286 286 Lines 64213 64664 +451 ==========================================
+ Hits 50538 51054 +516 + Misses 13675 13610 -65 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tustvold@codecov-io@kszucs@alamb@codecov-commenter@jorgecarleitao