Uh oh!
There was an error while loading. Please reload this page.
ARROW-12400: [Rust] Re-enable tests in arrow::array::transform - #10048
ARROW-12400: [Rust] Re-enable tests in arrow::array::transform#10048tustvold wants to merge 1 commit into
Conversation
Signed-off-by: Raphael Taylor-Davies <r.taylordavies@googlemail.com>
jorgecarleitao
left a comment
There was a problem hiding this comment.
Thanks a lot, @tustvold 👍
codecov-io
commented
Apr 15, 2021
Codecov Report
@@ Coverage Diff @@## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24%
==========================================
Files 286 286 Lines 64213 64664 +451 ==========================================
+ Hits 50538 51054 +516 + Misses 13675 13610 -65
Continue to review full report at Codecov.
|
kszucs
commented
Apr 15, 2021
@andygrove I assume we'd like to have it in the release. |
alamb
commented
Apr 15, 2021
FWIW @kszucs I don't think this is something that we should hold the release for -- it does not have any change to the actual code, only the tests. |
kszucs
commented
Apr 15, 2021
Ok, thought that implementation was affected as well. I'm still waiting for other PRs so feel free to merge on green. |
codecov-commenter
commented
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24%
==========================================
Files 286 286 Lines 64213 64664 +451 ==========================================
+ Hits 50538 51054 +516 + Misses 13675 13610 -65 ☔ View full report in Codecov by Sentry. |
These tests were all commented out in #9329. Given the PR made changes to the commented out code, I'm inclined to think this was an accidental omission? If not, happy for this to be closed 😀
FYI @jorgecarleitao
Signed-off-by: Raphael Taylor-Davies r.taylordavies@googlemail.com