Skip to content

ARROW-12575: [R] Use unary negative kernel#10196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thisisnic wants to merge 7 commits into from
Closed

ARROW-12575: [R] Use unary negative kernel #10196

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8eb70b3
Implement negate and add test
thisisnic Apr 29, 2021
7eed0cd
Typofix
thisisnic Apr 29, 2021
09da203
Implement negate for dataset expressions
thisisnic May 3, 2021
631000c
Remove test as we don't test other array/dataset functions
thisisnic May 3, 2021
4d2894c
Update build_dataset_impression
thisisnic May 3, 2021
288e06e
Remove unnecessary unary mapping
thisisnic May 3, 2021
031838d
Use negate_checked
thisisnic May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions r/R/expression.R
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,13 +56,9 @@ build_array_expression <- function(FUN,
args = list(...),
options = empty_named_list()) {
if (FUN == "-" && length(args) == 1L) {
# Unary -, i.e. just make it negative, and somehow this works
if (inherits(args[[1]], c("ArrowObject", "array_expression"))) {
# Make it be 0 - arg
# TODO(ARROW-11950): do this in C++ compute
args <- list(0L, args[[1]])
return(build_array_expression("negate_checked", args[[1]]))
} else {
# Somehow this works
return(-args[[1]])
}
}
Expand DownExpand Up@@ -288,12 +284,9 @@ build_dataset_expression <- function(FUN,
args = list(...),
options = empty_named_list()) {
if (FUN == "-" && length(args) == 1L) {
# Unary -, i.e. make it negative
if (inherits(args[[1]], c("ArrowObject", "Expression"))) {
# TODO(ARROW-11950): do this in C++ compute
args <- list(0L, args[[1]])
return(build_dataset_expression("negate_checked", args[[1]]))
} else {
# Somehow this just works
return(-args[[1]])
}
}
Expand Down