Uh oh!
There was an error while loading. Please reload this page.
ARROW-12715: [C++][Python] Add SQL LIKE match kernel - #10356
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ianmcook
commented
May 19, 2021
P.S. case insensitivity can be achieved by using one of the |
lidavidm
commented
May 19, 2021
We could easily add a flag to toggle insensitivity in RE2 as well. (Would be better than allocating a new string and potentially dealing with Unicode.) |
ianmcook
commented
May 19, 2021
But can |
lidavidm
commented
May 19, 2021
No, but in that case we'd just not dispatch to that path. |
ianmcook
commented
May 19, 2021
What to do about the options class might be awkward. You could subclass |
lidavidm
commented
May 20, 2021
We could add it to |
ianmcook
commented
May 20, 2021
Sounds good. The case-(in)sensitive option should be optional and should default to case-sensitive. We should error in cases where case-insensitive match is specified in the options but is ignored by a kernel or by any path in a kernel. This sounds to me like a separate PR. Should I open a Jira for that? |
lidavidm
commented
May 20, 2021
I filed ARROW-12835. I think this PR should be otherwise good-to-go then, unless we need to also add R bindings. |
ianmcook
commented
May 20, 2021
I think it's good to go. Nothing is needed in the R bindings. |
lidavidm
commented
May 20, 2021
Merged, thanks for the review! |
Implements a simple SQL LIKE pattern match kernel by translating it to a regex (or substring) match as appropriate.