Uh oh!
There was an error while loading. Please reload this page.
ARROW-12859: [C++] Add ScalarFromJSON for testing - #10386
Conversation
There was a problem hiding this comment.
This approach might be worthwhile for consistency's sake, but we could also use Scalar::CastTo
pitrou
commented
Jun 1, 2021
Is there anything left to do here? |
lidavidm
commented
Jun 1, 2021
I don't think so unless we really want to use Scalar::CastTo here. |
pitrou
commented
Jun 1, 2021
Can you explain the Also, I notice this isn't actually tested? Perhaps add a test alongside those for |
lidavidm
commented
Jun 1, 2021
For CastTo: I think it was actually the Cast kernel (string->type cast). I added some basic tests. I don't think there's a good way to hit the DCHECK because that would imply a JSON value converter appended two array values for a single JSON value. |
Uh oh!
There was an error while loading. Please reload this page.