Skip to content

ARROW-12975: [C++][Python] if_else kernel doesn't support upcasting - #10472

Closed
nirandaperera wants to merge 5 commits into
apache:masterfrom
nirandaperera:ARROW-12975
Closed

ARROW-12975: [C++][Python] if_else kernel doesn't support upcasting #10472
nirandaperera wants to merge 5 commits into
apache:masterfrom
nirandaperera:ARROW-12975

Conversation

@nirandaperera

@nirandapereranirandaperera commented Jun 7, 2021

Copy link
Copy Markdown
Contributor

Allowing if-else operation for following use cases

>>>pc.if_else([True], [1], [3.5])

@github-actions

github-actionsBot commented Jun 7, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-12975

bkietz
bkietz reviewed Jun 7, 2021
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
@nirandaperera
nirandaperera requested a review from bkietzJune 7, 2021 20:26
@nirandaperera
nirandaperera marked this pull request as ready for review June 7, 2021 20:26
bkietz
bkietz requested changes Jun 7, 2021
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else_test.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
@nirandaperera
nirandaperera requested a review from bkietzJune 7, 2021 21:21
bkietz
bkietz approved these changes Jun 8, 2021
View reviewed changes

@bkietzbkietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Before merging, could you rebase to pick up the fix for https://issues.apache.org/jira/browse/ARROW-12998 and clean up CI?

@bkietzbkietz closed this in 97a1c26Jun 9, 2021
@asfimportasfimport mentioned this pull request Jun 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkietzbkietzbkietz approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nirandaperera@bkietz